Summary: | [GTK] Webkit does not check if windows are X11 windows before calling gtk_window_* | ||
---|---|---|---|
Product: | WebKit | Reporter: | Jérôme Guelfucci <jeromeg> |
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Normal | CC: | elima, mrobinson |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Jérôme Guelfucci
2011-06-04 06:20:41 PDT
Is it possible for you to verify this is still an issue with the 1.4.0 or development releases? I can't test with those versions but reading the code of 1.4.0, I still see gtk_window_* usage without any other check than gtk_widget_is_toplevel () in ChromeClientGtk.cpp. I tested WebKitGTK 1.11.4 (trunk from Jan 29th, 2013) with GTK offscreen windows and it seems to be working fine. Looking at ChromeClientGtk.cpp there are checks for the presence of onscreen window (through widgetIsOnscreenToplevelWindow()) before all calls to gtk_window_*. So, so this bug no longer holds and I think it can be closed as already fixed. Though, I wonder if we need to add a test that verifies sanity with GTK offscreen windows. |