Bug 62089

Summary:

[Qt] Fix and unskip acid2

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

New Bugs

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, kling, ossy

Priority:

Keywords:

LayoutTestFailure, Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

62108

Attachments:

Description	Flags
Patch	kling: review+

Description Robert Hogan 2011-06-04 05:08:31 PDT

[Qt] Fix and unskip acid2

Comment 1 Robert Hogan 2011-06-04 05:20:20 PDT

Created attachment 96019 [details]
Patch

Comment 2 Benjamin Poulain 2011-06-04 06:29:44 PDT

Adding Andreas, he knows the frame loader a lot better than I do.

Comment 3 Andreas Kling 2011-06-04 07:06:41 PDT

Comment on attachment 96019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96019&action=review

Looks good, r=me.

> Source/WebKit/qt/ChangeLog:18
> +        Some ports also check when WebKitErrorPluginWillHandleLoad deciding
> +        what to return. This error isn't currently set by Qt so we don't check

This looks a bit jumbled.
Some ports also check WebKitErrorPluginWillHandleLoad when deciding what to return?

> Source/WebKit/qt/ChangeLog:20
> +        it. (Other ports set it when the erring document is a MediaDocument, maybe
> +        we should do that too at some point).

Sounds like you should file a bug about that. :)

Comment 4 Robert Hogan 2011-06-05 13:13:09 PDT

Committed r88135: <http://trac.webkit.org/changeset/88135>