Bug 62074

Summary: [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nico Weber
Reported 2011-06-03 17:22:50 PDT
[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
Attachments
Patch (1.52 KB, patch)
2011-06-03 17:23 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-06-03 17:23:34 PDT
Created attachment 95995 [details] Patch
WebKit Review Bot
Comment 2 2011-06-04 04:07:00 PDT
Comment on attachment 95995 [details] Patch Clearing flags on attachment: 95995 Committed r88108: <http://trac.webkit.org/changeset/88108>
WebKit Review Bot
Comment 3 2011-06-04 04:07:04 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 4 2011-06-04 11:20:39 PDT
Comment on attachment 95995 [details] Patch Virtual functions in headers should be out-of-line, right?
Note You need to log in before you can comment on or make changes to this bug.