Bug 62074 - [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
Summary: [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 17:22 PDT by Nico Weber
Modified: 2011-06-04 11:20 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.52 KB, patch)
2011-06-03 17:23 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-06-03 17:22:50 PDT 
[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
Comment 1 Nico Weber 2011-06-03 17:23:34 PDT 
Created attachment 95995 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-04 04:07:00 PDT 
Comment on attachment 95995 [details]
Patch

Clearing flags on attachment: 95995

Committed r88108: <http://trac.webkit.org/changeset/88108>
Comment 3 WebKit Review Bot 2011-06-04 04:07:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Adam Barth 2011-06-04 11:20:39 PDT 
Comment on attachment 95995 [details]
Patch

Virtual functions in headers should be out-of-line, right?