Bug 62072

Summary: [chromium] Make PlatformMessagePortChannel's destructor virtual
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Nico Weber
Reported 2011-06-03 17:08:15 PDT
[chromium] Make PlatformMessagePortChannel's destructor virtual
Attachments
Patch (1.50 KB, patch)
2011-06-03 17:09 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-06-03 17:09:13 PDT
Created attachment 95993 [details] Patch
Nico Weber
Comment 2 2011-06-03 17:09:57 PDT
Advantage of making only the leaf virtual: We don't need to touch WebCore here and annoy other ports (if they find changes of this type annoying)
Nico Weber
Comment 3 2011-06-03 17:14:43 PDT
Ignore the above comment; the interface is in chromiums webkit, so the comment is bogus
WebKit Review Bot
Comment 4 2011-06-04 03:58:59 PDT
Comment on attachment 95993 [details] Patch Clearing flags on attachment: 95993 Committed r88107: <http://trac.webkit.org/changeset/88107>
WebKit Review Bot
Comment 5 2011-06-04 03:59:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.