Bug 62065

Summary:

[chromium] Make WebFrameImpl destructor virtual

Product:

WebKit

Reporter:

Nico Weber <thakis>

Component:

New Bugs

Assignee:

Nico Weber <thakis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Nico Weber 2011-06-03 16:32:47 PDT

[chromium] Make WebFrameImpl destructor virtual

Comment 1 Nico Weber 2011-06-03 16:34:44 PDT

Created attachment 95984 [details]
Patch

Comment 2 James Robinson 2011-06-03 16:50:54 PDT

Comment on attachment 95984 [details]
Patch

WebFrame.h declares ~WebFrame() { }, so it should declare virtual there as well (of course you also need to declare virtual here).

Comment 3 Nico Weber 2011-06-03 16:53:00 PDT

(In reply to comment #2)
> (From update of attachment 95984 [details])
> WebFrame.h declares ~WebFrame() { }, so it should declare virtual there as well (of course you also need to declare virtual here).

Again, why? Nobody deletes a WebFrame directly, and its destructor is protected, so it won't happen accidentally.

Comment 4 WebKit Review Bot 2011-06-04 03:42:30 PDT

Comment on attachment 95984 [details]
Patch

Clearing flags on attachment: 95984

Committed r88105: <http://trac.webkit.org/changeset/88105>

Comment 5 WebKit Review Bot 2011-06-04 03:42:34 PDT

All reviewed patches have been landed.  Closing bug.