Bug 62046 – Allow existing AudioParams to use scheduled parameter changes

• Component: Web Audio
• Status: RESOLVED FIXED

[Chris Rogers]

Allow existing AudioParams to use scheduled parameter changes

[Chris Rogers]

Created attachment 95956 [details]
Patch

[Kenneth Russell]

Comment on attachment 95956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95956&action=review

Looks good to me. One minor comment.

> Source/WebCore/platform/audio/AudioBus.cpp:385
> +            const float* source = sourceBus.channel(channelIndex)->data();
> +            float* destination = channel(channelIndex)->data();
> +            for (unsigned i = 0; i < numberOfGainValues; ++i)
> +                destination[i] = source[i] * gainValues[i];
> +        }
> +    } else if (sourceBus.numberOfChannels() == 1) {
> +        const float* source = sourceBus.channel(0)->data();
> +        for (unsigned channelIndex = 0; channelIndex < numberOfChannels(); ++channelIndex) {
> +            float* destination = channel(channelIndex)->data();
> +            for (unsigned i = 0; i < numberOfGainValues; ++i)
> +                destination[i] = source[i] * gainValues[i];

Would be nice to avoid the duplicated code.

[Chris Rogers]

Comment on attachment 95956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95956&action=review

>> Source/WebCore/platform/audio/AudioBus.cpp:385
>> +                destination[i] = source[i] * gainValues[i];
> 
> Would be nice to avoid the duplicated code.

Agreed.  I'll try to coalesce these two cases.

[Chris Rogers]

Committed r88074: <http://trac.webkit.org/changeset/88074>