Summary: | Switch paintCaret and paintDragCaret to use IntPoint | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> | ||||
Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | crogers, darin, eae, eric, simon.fraser, simonjam, thakis | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 60318 | ||||||
Attachments: |
|
Description
Levi Weintraub
2011-06-03 12:02:21 PDT
Two is today's magic number. Created attachment 95944 [details]
Patch
Comment on attachment 95944 [details] Patch Clearing flags on attachment: 95944 Committed r88050: <http://trac.webkit.org/changeset/88050> All reviewed patches have been landed. Closing bug. This caused the Mac Clang bot to fail. Can you take a look? http://build.chromium.org/p/chromium/builders/Mac%20Clang%20%28dbg%29/builds/3810/steps/compile/logs/stdio Hi this breaks the clang build thusly: clang:warning: argument unused during compilation: '-fobjc-exceptions' /b/build/slave/Mac_Clang__dbg_/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../webaudio/AudioParamTimeline.cpp:231:39:error: operands of ? are integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare] int nextEventType = nextEvent ? nextEvent->type() : -1 /* unknown */; Can you fix? That can't be this change. |