Bug 62029

Summary: Cleanup member variable usage in svg/animation classes
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: SVGAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zimmermann: review+

Rob Buis
Reported 2011-06-03 10:03:38 PDT
There is one case where member var reordering decreases the class instance size, and another one where member vars can be removed since the state does not need to be stored, it is just used once.
Attachments
Patch (5.47 KB, patch)
2011-06-03 10:07 PDT, Rob Buis 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2011-06-03 10:07:13 PDT
Created attachment 95925 [details] Patch
Nikolas Zimmermann
Comment 2 2011-06-03 12:25:07 PDT
Comment on attachment 95925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95925&action=review r=me with a comment: > Source/WebCore/svg/animation/SMILTimeContainer.cpp:222 > +void SMILTimeContainer::updateAnimations(SMILTime elapsed, double nextManualSampleTime, String nextSamplingTarget) Use const String&. > Source/WebCore/svg/animation/SMILTimeContainer.h:73 > + void updateAnimations(SMILTime elapsed, double nextManualSampleTime = 0, String nextSamplingTarget = String()); Do we need the default params? If yes, you can't switch const String&...
Rob Buis
Comment 3 2011-06-03 12:37:34 PDT
Committed r88039: <http://trac.webkit.org/changeset/88039>
Note You need to log in before you can comment on or make changes to this bug.