Bug 62022

Summary: Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: bashi, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch V0 none

David Levin
Reported 2011-06-03 08:39:06 PDT
For example see https://bugs.webkit.org/attachment.cgi?id=95523&action=prettypatch
Attachments
Patch V0 (9.33 KB, patch)
2011-06-30 19:32 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-06-03 12:25:31 PDT
And it should ideally suggest what to do so that this doesn't happen again!
Kenichi Ishibashi
Comment 2 2011-06-30 19:32:54 PDT
Created attachment 99417 [details] Patch V0
Darin Adler
Comment 3 2011-06-30 19:47:01 PDT
Comment on attachment 99417 [details] Patch V0 Seems fine.
Kenichi Ishibashi
Comment 4 2011-06-30 19:59:51 PDT
Comment on attachment 99417 [details] Patch V0 Clearing flags on attachment: 99417 Committed r90197: <http://trac.webkit.org/changeset/90197>
Kenichi Ishibashi
Comment 5 2011-06-30 19:59:57 PDT
All reviewed patches have been landed. Closing bug.
Kenichi Ishibashi
Comment 6 2011-06-30 20:00:59 PDT
Hi Darin, Thank you for prompt review! (In reply to comment #3) > (From update of attachment 99417 [details]) > Seems fine.
Note You need to log in before you can comment on or make changes to this bug.