Bug 62014
| Summary: | Undefined reference to v8::HeapProfiler::DefineWrapperClass() due to ScriptProfiler::initialize() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Steve Block <steveblock> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mnaganov, pfeldman, steveblock |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Steve Block
http://trac.webkit.org/changeset/81265 added ScriptProfiler::initialize(), which calls v8::HeapProfiler::DefineWrapperClass().
On Android, this gives a linker error because we build v8 without ENABLE_LOGGING_AND_PROFILING defined.
Should there be enable guard around either the call site (in V8DOMWindowShell::initContextIfNeeded()) or implementation of ScriptProfiler::initialize() ?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mikhail Naganov
I'm sorry! Will fix today.
Mikhail Naganov
Fixed in V8: http://code.google.com/p/v8/source/detail?r=8170
I have defined stub implementations when profiling is disabled (consistent with the rest of the API implementation).
BTW, we are planning to do something with this option, as Crankshaft can't work w/o profiler parts. See http://code.google.com/p/v8/issues/detail?id=1271
Steve Block
Thanks Mikhail