Bug 62009

Summary: IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dgrogan, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch steveblock: review+, commit-queue: commit-queue-

Hans Wennborg
Reported 2011-06-03 05:43:04 PDT
IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
Attachments
Patch (14.42 KB, patch)
2011-06-03 05:45 PDT, Hans Wennborg 		no flags
DetailsFormatted DiffDiff
Patch (14.69 KB, patch)
2011-06-03 07:45 PDT, Hans Wennborg 		steveblock: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hans Wennborg
Comment 1 2011-06-03 05:45:24 PDT
Created attachment 95901 [details] Patch
Hans Wennborg
Comment 2 2011-06-03 05:46:33 PDT
Some clean-up that's been asked for in previous reviews.
Steve Block
Comment 3 2011-06-03 06:03:52 PDT
Comment on attachment 95901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95901&action=review > Source/WebCore/storage/IDBLevelDBCoding.cpp:755 > + return encode(INT64_MAX); Should the FIXME for INT64_MAX in this file be removed?
Hans Wennborg
Comment 4 2011-06-03 06:09:11 PDT
Comment on attachment 95901 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95901&action=review >> Source/WebCore/storage/IDBLevelDBCoding.cpp:755 >> + return encode(INT64_MAX); > > Should the FIXME for INT64_MAX in this file be removed? Yes, I'll do that.
Hans Wennborg
Comment 5 2011-06-03 07:45:05 PDT
Created attachment 95911 [details] Patch
Steve Block
Comment 6 2011-06-03 07:47:24 PDT
Comment on attachment 95911 [details] Patch r=me
WebKit Commit Bot
Comment 7 2011-06-03 07:55:19 PDT
Comment on attachment 95911 [details] Patch Rejecting attachment 95911 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8764126
Hans Wennborg
Comment 8 2011-06-03 08:03:10 PDT
Committed r88019: <http://trac.webkit.org/changeset/88019>
Note You need to log in before you can comment on or make changes to this bug.