Bug 61998

Summary: [EFL] Implement startDownload() in FrameLoaderClientEfl
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on: 62017    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2011-06-03 01:01:01 PDT
Implement startDownload(). I think startDownload() operation is same with download().
Attachments
Patch (1.47 KB, patch)
2011-06-03 01:03 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.47 KB, patch)
2011-06-06 17:29 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-06-03 01:03:37 PDT
Created attachment 95869 [details] Patch
WebKit Commit Bot
Comment 2 2011-06-03 07:17:57 PDT
Comment on attachment 95869 [details] Patch Clearing flags on attachment: 95869 Committed r88014: <http://trac.webkit.org/changeset/88014>
WebKit Commit Bot
Comment 3 2011-06-03 07:18:02 PDT
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 4 2011-06-03 07:48:14 PDT
Scanning dependencies of target ewebkit [100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.o /mnt/buildbot/efl-linux-slave-1/efl-linux-release/build/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp: In member function ‘virtual void WebCore::FrameLoaderClientEfl::startDownload(const WebCore::ResourceRequest&)’: /mnt/buildbot/efl-linux-slave-1/efl-linux-release/build/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:875: error: ‘const class WebCore::KURL’ has no member named ‘prettyURL’ make[2]: *** [WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.o] Error 1 make[1]: *** [WebKit/CMakeFiles/ewebkit.dir/all] Error 2
Antonio Gomes
Comment 5 2011-06-03 08:50:36 PDT
Rolled out. Please re-push a patch that builds.
Gyuyoung Kim
Comment 6 2011-06-06 17:29:47 PDT
Created attachment 96162 [details] Patch
Gyuyoung Kim
Comment 7 2011-06-06 17:54:49 PDT
Comment on attachment 96162 [details] Patch Hmm, strange build error. There is no build problem in my local box. If this patch make build break again, I'm going to roll out again.
WebKit Review Bot
Comment 8 2011-06-06 18:03:40 PDT
Comment on attachment 96162 [details] Patch Clearing flags on attachment: 96162 Committed r88207: <http://trac.webkit.org/changeset/88207>
WebKit Review Bot
Comment 9 2011-06-06 18:03:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.