Bug 61954

Summary: [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, nduca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+

Adrienne Walker
Reported 2011-06-02 13:09:54 PDT
[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
Attachments
Patch (2.32 KB, patch)
2011-06-02 13:13 PDT, Adrienne Walker 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2011-06-02 13:13:59 PDT
Created attachment 95795 [details] Patch
James Robinson
Comment 2 2011-06-02 14:02:24 PDT
Comment on attachment 95795 [details] Patch Looks good. Is there any reasonable way to share the CCHeadsUpDisplay uploading logic with the code we use for content layers so we don't have to do this stuff twice?
Adrienne Walker
Comment 3 2011-06-02 14:09:44 PDT
We could probably add a tiler to the CCHeadsUpDisplay and replace all the drawing and uploading code. That looked like a lot more invasive of a change, so I thought I'd just fix the crash initially and consider refactoring later.
Adrienne Walker
Comment 4 2011-06-02 15:14:20 PDT
Committed r87960: <http://trac.webkit.org/changeset/87960>
Note You need to log in before you can comment on or make changes to this bug.