Bug 61949

Summary: Rename IntPoint/IntRect/FloatPoint/FloatRect::move to moveBy
Product: WebKit Reporter: Emil A Eklund <eae>
Component: WebCore Misc.Assignee: Emil A Eklund <eae>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, dglazkov, eric, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 61891    
Bug Blocks: 61893    
Attachments:
Description Flags
Patch none

Description Emil A Eklund 2011-06-02 11:41:27 PDT 
From comment on bug 61893:

Bleh.  I'm liking generic move(IntPoint) less and less.  it's not clear if it sets or moves.
I think we should consider renaming the move() calls to moveBy() or something to make it clear what move(Point) is doing.  (I know rect and IntPoint use the same naming, so maybe that should be a separate change?)
Comment 1 Emil A Eklund 2011-06-02 15:04:00 PDT 
Follows up on the work started by levi in bug 61891.
Comment 2 Emil A Eklund 2011-06-02 15:11:52 PDT 
Created attachment 95820 [details]
Patch
Comment 3 Emil A Eklund 2011-06-02 15:12:36 PDT 
Upload early to get feedback on whether this is a good idea or not. I suspect there are other platform specific files that needs to be updated as well.
Comment 4 WebKit Review Bot 2011-06-02 15:30:13 PDT 
Comment on attachment 95820 [details]
Patch

Attachment 95820 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8756833