Bug 61945

Summary: [Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop webgl
Product: WebKit Reporter: Idrees <sidreesshah>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Test case
none
Fix for the bug.
none
Patch for the fix.
none
Fix for the bug. none

Idrees
Reported 2011-06-02 11:17:08 PDT
Created attachment 95780 [details] Test case LayoutTests/fast/canvas/webgl/point-size.html is failing for desktop qtwebkit. GL_VERTEX_PROGRAM_POINT_SIZE is not enabled for desktop qt opengl.
Attachments
Test case (3.78 KB, text/html)
2011-06-02 11:17 PDT, Idrees 		no flags
Details
Fix for the bug. (1.61 KB, patch)
2011-06-02 11:30 PDT, Idrees 		no flags
DetailsFormatted DiffDiff
Patch for the fix. (1.61 KB, patch)
2011-06-02 12:59 PDT, Idrees 		no flags
DetailsFormatted DiffDiff
Fix for the bug. (1.61 KB, patch)
2011-06-02 13:01 PDT, Idrees 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Idrees
Comment 1 2011-06-02 11:19:08 PDT
On furhter investigation i found out that it is not required for opengl es to enable GL_VERTEX_PROGRAM_POINT_SIZE or GL_POINT_SPRITE. but for opengl desktop we need to enable this feature.
Idrees
Comment 2 2011-06-02 11:30:58 PDT
Created attachment 95782 [details] Fix for the bug. I have enabled the feature only for desktop QtWebKit Webgl.
Andreas Kling
Comment 3 2011-06-02 12:45:31 PDT
Comment on attachment 95782 [details] Fix for the bug. View in context: https://bugs.webkit.org/attachment.cgi?id=95782&action=review Is this not testable? > Source/WebCore/ChangeLog:5 > + [QT] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop webgl QT -> Qt webgl -> WebGL > Source/WebCore/ChangeLog:9 > + For Opengl ES we do not need these features. > + These features are available via shadders in Opengl ES. But for desktop WebGL using QtWebkit they should be enabled. Opengl -> OpenGL shadders -> shaders QtWebkit -> QtWebKit
Idrees
Comment 4 2011-06-02 12:59:06 PDT
(In reply to comment #3) > (From update of attachment 95782 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95782&action=review > > Is this not testable? I am doing the development and testing on linux desktop with OpenGL. So it is testable there. For OpenGL ES, I found out that its not required. But i have not tested it with OpenGL ES. For linux desktop with OpenGL it is definitely testable.
Idrees
Comment 5 2011-06-02 12:59:50 PDT
Created attachment 95790 [details] Patch for the fix. Fixing typos.
Idrees
Comment 6 2011-06-02 13:01:19 PDT
Created attachment 95792 [details] Fix for the bug. more typos.
WebKit Review Bot
Comment 7 2011-06-08 03:33:23 PDT
Comment on attachment 95792 [details] Fix for the bug. Clearing flags on attachment: 95792 Committed r88335: <http://trac.webkit.org/changeset/88335>
WebKit Review Bot
Comment 8 2011-06-08 03:33:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.