Bug 61893

Summary: Switch ContainerNode to use IntPoint
Product: WebKit Reporter: Emil A Eklund <eae>
Component: DOMAssignee: Emil A Eklund <eae>
Severity: Normal CC: eric, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 61949    
Bug Blocks: 60318    
Description Flags
Patch for landing none

Description Emil A Eklund 2011-06-01 16:35:04 PDT
ContainerNode uses x, y, w, h in a couple of places when dealing with render boxes and line layout. Convert this to points and sizes instead.
Comment 1 Emil A Eklund 2011-06-01 17:03:30 PDT
Created attachment 95690 [details]
Comment 2 Eric Seidel (no email) 2011-06-02 08:33:47 PDT
Comment on attachment 95690 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=95690&action=review

I think we should consider renaming the move() calls to moveBy() or something to make it clear what move(Point) is doing.  (I know rect and IntPoint use the same naming, so maybe that should be a separate change?)

> Source/WebCore/dom/ContainerNode.cpp:881
> +                point.move(box->location());

Bleh.  I'm liking generic move(IntPoint) less and less.  it's not clear if it sets or moves.

> Source/WebCore/dom/ContainerNode.cpp:907
> +        point.move(box->size());

move(Size) is OK, but we still might want to rename both of these to moveBy.

> Source/WebCore/platform/graphics/FloatPoint.h:107
> +        return IntPoint(m_x > other.m_x ? m_x : other.m_x,
> +            m_y > other.m_y ? m_y : other.m_y);

I don't think the wrapping his helpful here.
Comment 3 Emil A Eklund 2011-06-07 11:41:32 PDT
Created attachment 96271 [details]
Comment 4 Eric Seidel (no email) 2011-06-07 12:04:26 PDT
Comment on attachment 96271 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=96271&action=review

> Source/WebCore/platform/graphics/FloatPoint.h:125
> +        return FloatPoint(m_x > other.m_x ? m_x : other.m_x, m_y > other.m_y ? m_y : other.m_y);

This sounds like std::min/std::max....
Comment 5 Emil A Eklund 2011-06-07 12:08:06 PDT
Thanks, didn't realize we could use std::min/max in WebCore.
Comment 6 Emil A Eklund 2011-06-07 12:51:44 PDT
Created attachment 96286 [details]
Patch for landing
Comment 7 WebKit Review Bot 2011-06-07 14:06:39 PDT
Comment on attachment 96286 [details]
Patch for landing

Clearing flags on attachment: 96286

Committed r88264: <http://trac.webkit.org/changeset/88264>
Comment 8 WebKit Review Bot 2011-06-07 14:06:43 PDT
All reviewed patches have been landed.  Closing bug.