Summary: | Switch ContainerNode to use IntPoint | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||
Component: | DOM | Assignee: | Emil A Eklund <eae> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric, leviw, simon.fraser, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 61949 | ||||||||||
Bug Blocks: | 60318 | ||||||||||
Attachments: |
|
Description
Emil A Eklund
2011-06-01 16:35:04 PDT
Created attachment 95690 [details]
Patch
Comment on attachment 95690 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95690&action=review I think we should consider renaming the move() calls to moveBy() or something to make it clear what move(Point) is doing. (I know rect and IntPoint use the same naming, so maybe that should be a separate change?) > Source/WebCore/dom/ContainerNode.cpp:881 > + point.move(box->location()); Bleh. I'm liking generic move(IntPoint) less and less. it's not clear if it sets or moves. > Source/WebCore/dom/ContainerNode.cpp:907 > + point.move(box->size()); move(Size) is OK, but we still might want to rename both of these to moveBy. > Source/WebCore/platform/graphics/FloatPoint.h:107 > + return IntPoint(m_x > other.m_x ? m_x : other.m_x, > + m_y > other.m_y ? m_y : other.m_y); I don't think the wrapping his helpful here. Created attachment 96271 [details]
Patch
Comment on attachment 96271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96271&action=review > Source/WebCore/platform/graphics/FloatPoint.h:125 > + return FloatPoint(m_x > other.m_x ? m_x : other.m_x, m_y > other.m_y ? m_y : other.m_y); This sounds like std::min/std::max.... Thanks, didn't realize we could use std::min/max in WebCore. Created attachment 96286 [details]
Patch for landing
Comment on attachment 96286 [details] Patch for landing Clearing flags on attachment: 96286 Committed r88264: <http://trac.webkit.org/changeset/88264> All reviewed patches have been landed. Closing bug. |