Bug 61881

Summary: gyp_webkit reports errors when advancing chromium_rev past version 87140
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, evan, levin, thakis, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Aaron Colwell
Reported 2011-06-01 13:32:26 PDT
A change was made in chromium version 87140 that breaks the WebKit build if you try to advance chromium_rev in Source/WebKit/chromium/DEPS past this version. A patch will be submitted shortly to bring gyp_webkit in line with the changes made to gyp_chromium.
Attachments
Patch (1.48 KB, patch)
2011-06-01 13:38 PDT, Aaron Colwell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aaron Colwell
Comment 1 2011-06-01 13:37:07 PDT
Original Chromium bug http://code.google.com/p/chromium/issues/detail?id=84611
Aaron Colwell
Comment 2 2011-06-01 13:38:40 PDT
Created attachment 95652 [details] Patch
Aaron Colwell
Comment 3 2011-06-02 09:27:37 PDT
ping. C
Nico Weber
Comment 4 2011-06-02 09:30:41 PDT
This change is correct – lgtm.
Dimitri Glazkov (Google)
Comment 5 2011-06-02 09:31:33 PDT
Comment on attachment 95652 [details] Patch I HAZ RUBBER STAMP.
Aaron Colwell
Comment 6 2011-06-02 09:36:57 PDT
Thanks.
WebKit Commit Bot
Comment 7 2011-06-02 10:41:05 PDT
Comment on attachment 95652 [details] Patch Clearing flags on attachment: 95652 Committed r87927: <http://trac.webkit.org/changeset/87927>
WebKit Commit Bot
Comment 8 2011-06-02 10:41:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.