Bug 61874

Summary: Switch paintScrollCorner to use IntPoint
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch none

Description Levi Weintraub 2011-06-01 11:35:17 PDT
More tx/ty removal...
Comment 1 Levi Weintraub 2011-06-01 11:54:09 PDT
Created attachment 95638 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-01 12:26:43 PDT
Comment on attachment 95638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review

OK.

> Source/WebCore/rendering/RenderLayer.cpp:2338
> +    IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height());

This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset)
Comment 3 Levi Weintraub 2011-06-01 12:35:37 PDT
Comment on attachment 95638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95638&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:2338
>> +    IntRect absRect = IntRect(cornerRect.x() + paintOffset.x(), cornerRect.y() + paintOffset.y(), cornerRect.width(), cornerRect.height());
> 
> This might be simpler as as IntRect absRect = cornerRect; absRect.move(paintOffset)

Agreed! I'll change it and land. Thanks for the review!
Comment 4 Levi Weintraub 2011-06-01 13:38:25 PDT
Committed r87841: <http://trac.webkit.org/changeset/87841>