Bug 61870

Summary: LayoutTests/editing/pasteboard/drag-drop-list fails on GTK
Product: WebKit Reporter: Annie Sullivan <sullivan>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 61661    
Bug Blocks: 61683    
Attachments:
Description Flags
Patch
none
Patch none

Annie Sullivan
Reported 2011-06-01 10:49:33 PDT
On GTK, a newline is not inserted when the text is dropped. There needs to be a platform-specific test for this.
Attachments
Patch (1.61 KB, patch)
2011-06-01 10:51 PDT, Annie Sullivan 		no flags
DetailsFormatted DiffDiff
Patch (1.63 KB, patch)
2011-06-01 11:35 PDT, Annie Sullivan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Annie Sullivan
Comment 1 2011-06-01 10:51:13 PDT
Created attachment 95624 [details] Patch
Ryosuke Niwa
Comment 2 2011-06-01 11:28:56 PDT
Comment on attachment 95624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review > LayoutTests/ChangeLog:8 > + Add platform-specific expected result for GTK, without newline. You mean without a space?
Annie Sullivan
Comment 3 2011-06-01 11:32:37 PDT
(In reply to comment #2) > (From update of attachment 95624 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review > > > LayoutTests/ChangeLog:8 > > + Add platform-specific expected result for GTK, without newline. > > You mean without a space? Originally, it was " ". The  character is a newline, right? So would it be better to say "without newline and space"?
Ryosuke Niwa
Comment 4 2011-06-01 11:33:16 PDT
Comment on attachment 95624 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review >>> LayoutTests/ChangeLog:8 >>> + Add platform-specific expected result for GTK, without newline. >> >> You mean without a space? > > Originally, it was " ". The  character is a newline, right? So would it be better to say "without newline and space"? I think it's nbsp.
Annie Sullivan
Comment 5 2011-06-01 11:35:03 PDT
Created attachment 95635 [details] Patch
Annie Sullivan
Comment 6 2011-06-01 11:35:41 PDT
(In reply to comment #4) > (From update of attachment 95624 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95624&action=review > > >>> LayoutTests/ChangeLog:8 > >>> + Add platform-specific expected result for GTK, without newline. > >> > >> You mean without a space? > > > > Originally, it was " ". The  character is a newline, right? So would it be better to say "without newline and space"? > > I think it's nbsp. Oh, thanks! ChangeLog updated.
Ryosuke Niwa
Comment 7 2011-06-01 11:52:02 PDT
I think we should add to GTK's skipped list. Look at around line 357 of LayoutTests/platform/gtk/Skipped. There's a list of bugs that are listed under the bug 61661.
Ryosuke Niwa
Comment 8 2011-06-01 12:08:18 PDT
The test is added to the skipped list in http://trac.webkit.org/changeset/87835.
Note You need to log in before you can comment on or make changes to this bug.