Bug 61869

Summary: [Qt] Fix the Phonon build when logging is disabled
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: Tools / TestsAssignee: Andras Becsi <abecsi>
Severity: Major CC: ademar, commit-queue, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Description Flags
proposed fix none

Description Andras Becsi 2011-06-01 09:50:55 PDT
When building without qt-mobility using Phonon as media back-end the build fails with "variable set but not used" errors because of -Werror=unused-but-set-variable. These variables are only used by unguarded LOG calls, which need "#if !LOG_DISABLED" guards.
Comment 1 Andras Becsi 2011-06-01 09:52:58 PDT
Created attachment 95616 [details]
proposed fix
Comment 2 WebKit Commit Bot 2011-06-01 11:16:26 PDT
Comment on attachment 95616 [details]
proposed fix

Clearing flags on attachment: 95616

Committed r87828: <http://trac.webkit.org/changeset/87828>
Comment 3 WebKit Commit Bot 2011-06-01 11:16:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2011-06-03 14:01:17 PDT
Revision r87828 cherry-picked into qtwebkit-2.2 with commit 875e920 <http://gitorious.org/webkit/qtwebkit/commit/875e920>