Bug 61869 - [Qt] Fix the Phonon build when logging is disabled
Summary: [Qt] Fix the Phonon build when logging is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Major
Assignee: Andras Becsi
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-06-01 09:50 PDT by Andras Becsi
Modified: 2011-06-03 14:01 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (3.51 KB, patch)
2011-06-01 09:52 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2011-06-01 09:50:55 PDT 
When building without qt-mobility using Phonon as media back-end the build fails with "variable set but not used" errors because of -Werror=unused-but-set-variable. These variables are only used by unguarded LOG calls, which need "#if !LOG_DISABLED" guards.
Comment 1 Andras Becsi 2011-06-01 09:52:58 PDT 
Created attachment 95616 [details]
proposed fix
Comment 2 WebKit Commit Bot 2011-06-01 11:16:26 PDT 
Comment on attachment 95616 [details]
proposed fix

Clearing flags on attachment: 95616

Committed r87828: <http://trac.webkit.org/changeset/87828>
Comment 3 WebKit Commit Bot 2011-06-01 11:16:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2011-06-03 14:01:17 PDT 
Revision r87828 cherry-picked into qtwebkit-2.2 with commit 875e920 <http://gitorious.org/webkit/qtwebkit/commit/875e920>