Bug 61846

Summary: [EFL] Add null checking condition to EditorClientEfl.cpp
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, kenneth, lucas.de.marchi, tkent, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Gyuyoung Kim 2011-06-01 01:41:52 PDT 
In EditorClientEfl::handleEditingKeyboardEvent(), it uses caretBrowsingEnabled() of settings(). However, it doesn't check if settings() is null.
settgins() of frame can be null.

Frame.h 
   Settings* settings() const; // can be NULL
Comment 1 Gyuyoung Kim 2011-06-01 01:44:55 PDT 
Created attachment 95566 [details]
Patch
Comment 2 Kent Tamura 2011-06-01 01:52:41 PDT 
Comment on attachment 95566 [details]
Patch

ok
Comment 3 WebKit Commit Bot 2011-06-01 04:41:08 PDT 
Comment on attachment 95566 [details]
Patch

Clearing flags on attachment: 95566

Committed r87794: <http://trac.webkit.org/changeset/87794>
Comment 4 WebKit Commit Bot 2011-06-01 04:41:13 PDT 
All reviewed patches have been landed.  Closing bug.