Bug 61846

Summary: [EFL] Add null checking condition to EditorClientEfl.cpp
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, kenneth, lucas.de.marchi, tkent, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch none

Gyuyoung Kim
Reported 2011-06-01 01:41:52 PDT
In EditorClientEfl::handleEditingKeyboardEvent(), it uses caretBrowsingEnabled() of settings(). However, it doesn't check if settings() is null. settgins() of frame can be null. Frame.h Settings* settings() const; // can be NULL
Attachments
Patch (1.25 KB, patch)
2011-06-01 01:44 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-06-01 01:44:55 PDT
Created attachment 95566 [details] Patch
Kent Tamura
Comment 2 2011-06-01 01:52:41 PDT
Comment on attachment 95566 [details] Patch ok
WebKit Commit Bot
Comment 3 2011-06-01 04:41:08 PDT
Comment on attachment 95566 [details] Patch Clearing flags on attachment: 95566 Committed r87794: <http://trac.webkit.org/changeset/87794>
WebKit Commit Bot
Comment 4 2011-06-01 04:41:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.