Summary: | Web Inspector: [Chromium] DevTools worker scripts are not included into devtool_frontend.zip | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Mikhail Naganov <mnaganov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 61842 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Mikhail Naganov
2011-05-31 13:30:14 PDT
Created attachment 95473 [details]
patch
Created attachment 95480 [details]
put all source highlighter files
Manually committed http://trac.webkit.org/changeset/87781: 2011-05-31 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip. https://bugs.webkit.org/show_bug.cgi?id=61803 * WebKit.gyp: * scripts/generate_devtools_zip.py: The patch was rolled out (https://bugs.webkit.org/show_bug.cgi?id=61842) The reason is that Chromium bots run Python v2.4 which doesn't have os.path.relpath function yet. Created attachment 95563 [details]
avoid using os.path.relpath
Comment on attachment 95563 [details] avoid using os.path.relpath View in context: https://bugs.webkit.org/attachment.cgi?id=95563&action=review > Source/WebKit/chromium/scripts/generate_devtools_zip.py:74 > + return ParsedArgs(inspector_html, devtools_files, workers_files, You can put the whole expression in one line, there is no 80chars limit in WebKit. (In reply to comment #6) > (From update of attachment 95563 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95563&action=review > > > Source/WebKit/chromium/scripts/generate_devtools_zip.py:74 > > + return ParsedArgs(inspector_html, devtools_files, workers_files, > > You can put the whole expression in one line, there is no 80chars limit in WebKit. Fixed. Re-landed as http://trac.webkit.org/changeset/87786. 2011-06-01 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip. https://bugs.webkit.org/show_bug.cgi?id=61803 * WebKit.gyp: * scripts/generate_devtools_zip.py: |