Bug 61803

Summary:

Web Inspector: [Chromium] DevTools worker scripts are not included into devtool_frontend.zip

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

61842

Bug Blocks:

Attachments:

Description	Flags
patch	mnaganov: commit-queue-
put all source highlighter files	pfeldman: review+, mnaganov: commit-queue-
avoid using os.path.relpath	yurys: review+, mnaganov: commit-queue-

Mikhail Naganov

Reported 2011-05-31 13:30:14 PDT

From http://crbug.com/82614: Run Chromium against downloaded & unzipped devtools_frontend.zip (using --debug-devtools-frontend flag). It turns out, that worker scripts for text highlighting and heap profiles processing are missing in the archive, resulting in non-working functionality.

Attachments
patch (4.62 KB, patch) 2011-05-31 13:32 PDT, Mikhail Naganov	mnaganov: commit-queue-	Details Formatted Diff Diff
put all source highlighter files (5.25 KB, patch) 2011-05-31 14:10 PDT, Mikhail Naganov	pfeldman: review+ mnaganov: commit-queue-	Details Formatted Diff Diff
avoid using os.path.relpath (5.28 KB, patch) 2011-06-01 01:35 PDT, Mikhail Naganov	yurys: review+ mnaganov: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2011-05-31 13:32:57 PDT

Created attachment 95473 [details] patch

Mikhail Naganov

Comment 2 2011-05-31 14:10:13 PDT

Created attachment 95480 [details] put all source highlighter files

Mikhail Naganov

Comment 3 2011-06-01 00:47:51 PDT

Manually committed http://trac.webkit.org/changeset/87781: 2011-05-31 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip. https://bugs.webkit.org/show_bug.cgi?id=61803 * WebKit.gyp: * scripts/generate_devtools_zip.py:

Mikhail Naganov

Comment 4 2011-06-01 01:17:39 PDT

The patch was rolled out (https://bugs.webkit.org/show_bug.cgi?id=61842) The reason is that Chromium bots run Python v2.4 which doesn't have os.path.relpath function yet.

Mikhail Naganov

Comment 5 2011-06-01 01:35:49 PDT

Created attachment 95563 [details] avoid using os.path.relpath

Yury Semikhatsky

Comment 6 2011-06-01 01:40:13 PDT

Comment on attachment 95563 [details] avoid using os.path.relpath View in context: https://bugs.webkit.org/attachment.cgi?id=95563&action=review > Source/WebKit/chromium/scripts/generate_devtools_zip.py:74 > + return ParsedArgs(inspector_html, devtools_files, workers_files, You can put the whole expression in one line, there is no 80chars limit in WebKit.

Mikhail Naganov

Comment 7 2011-06-01 01:43:49 PDT

(In reply to comment #6) > (From update of attachment 95563 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95563&action=review > > > Source/WebKit/chromium/scripts/generate_devtools_zip.py:74 > > + return ParsedArgs(inspector_html, devtools_files, workers_files, > > You can put the whole expression in one line, there is no 80chars limit in WebKit. Fixed.

Mikhail Naganov

Comment 8 2011-06-01 02:07:01 PDT

Re-landed as http://trac.webkit.org/changeset/87786. 2011-06-01 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip. https://bugs.webkit.org/show_bug.cgi?id=61803 * WebKit.gyp: * scripts/generate_devtools_zip.py:

Note You need to log in before you can comment on or make changes to this bug.