Summary: | ASSERT in WebCore::HTMLToken::appendToAttributeName when visiting www.nba.com | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||
Component: | DOM | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Critical | CC: | abarth, ap, eric, etring, naiem.shaik, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | http://www.nba.com | ||||||||
Attachments: |
|
Description
Sergio Villar Senin
2011-05-31 02:14:48 PDT
Hi, is anybody looking into this? Is this a recent regression? Does this crash in release builds, or is this just an ASSERT? *** Bug 62958 has been marked as a duplicate of this bug. *** Bug 62958 has analysis in it: ------------------------- if there is a attribute in the end tag of script, like this: <script class="value"> ... </script class="value"> function appendToAttributeName in file HTMLToken.h assert when debug ------------------------- Created attachment 97770 [details]
Patch
Comment on attachment 97770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97770&action=review > LayoutTests/fast/parser/attributes-on-close-script.html:2 > +<script class="value"> Do we actually need the attribute on opening tag? It makes the test slightly confusing (does it matter that the opening tag has an attribute? does it need to be the same on opening and closing tags?) > LayoutTests/fast/parser/attributes-on-close-script.html:3 > +alert('PASS'); This is testing for an assertion failure, so test content or output should explain that ("PASS if no assertion failure occurred" would be sufficient). (In reply to comment #8) > (From update of attachment 97770 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97770&action=review > > > LayoutTests/fast/parser/attributes-on-close-script.html:2 > > +<script class="value"> > > Do we actually need the attribute on opening tag? It makes the test slightly confusing (does it matter that the opening tag has an attribute? does it need to be the same on opening and closing tags?) It's not needed. I'll remove it. > > LayoutTests/fast/parser/attributes-on-close-script.html:3 > > +alert('PASS'); > > This is testing for an assertion failure, so test content or output should explain that ("PASS if no assertion failure occurred" would be sufficient). Will do. Thanks! Created attachment 97818 [details]
Patch for landing
Comment on attachment 97818 [details] Patch for landing Clearing flags on attachment: 97818 Committed r89258: <http://trac.webkit.org/changeset/89258> All reviewed patches have been landed. Closing bug. |