Bug 61759

Summary: [Chromium] Make isValidProtocol() accept protocols with '+'.
Product: WebKit Reporter: James Kozianski <koz>
Component: New BugsAssignee: James Kozianski <koz>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch tkent: review+

James Kozianski
Reported 2011-05-30 21:32:33 PDT
[Chromium] Update registerProtocolHandler tests for chromium.
Attachments
Patch (5.90 KB, patch)
2011-05-30 21:38 PDT, James Kozianski 		no flags
DetailsFormatted DiffDiff
Patch (5.68 KB, patch)
2011-05-30 22:25 PDT, James Kozianski 		no flags
DetailsFormatted DiffDiff
Patch (5.67 KB, patch)
2011-05-30 22:46 PDT, James Kozianski 		no flags
DetailsFormatted DiffDiff
Patch (5.67 KB, patch)
2011-05-30 22:56 PDT, James Kozianski 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
James Kozianski
Comment 1 2011-05-30 21:38:10 PDT
Created attachment 95393 [details] Patch
James Kozianski
Comment 2 2011-05-30 22:25:28 PDT
Created attachment 95395 [details] Patch
Kent Tamura
Comment 3 2011-05-30 22:38:45 PDT
Comment on attachment 95395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95395&action=review > Source/WebCore/ChangeLog:10 > + Detect syntax errors before security errors. Could you write reasons why we need to detect syntax errors earlier? > Source/WebCore/ChangeLog:15 > +2011-05-30 James Kozianski <koz@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + [Chromium] Make isValidProtocol() accept protocols with '+'. > + https://bugs.webkit.org/show_bug.cgi?id=61759 > + > + * page/Navigator.cpp: > + (WebCore::Navigator::registerProtocolHandler): > + Detect syntax errors before security errors. > + * platform/KURLGoogle.cpp: > + (WebCore::isSchemeChar): > + Include '+' in the list of valid characters. > + > +2011-05-30 James Kozianski <koz@chromium.org> Teere are two ChangeLog entries.
James Kozianski
Comment 4 2011-05-30 22:46:40 PDT
Created attachment 95396 [details] Patch
James Kozianski
Comment 5 2011-05-30 22:47:47 PDT
Comment on attachment 95395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95395&action=review >> Source/WebCore/ChangeLog:10 >> + Detect syntax errors before security errors. > > Could you write reasons why we need to detect syntax errors earlier? Done. >> Source/WebCore/ChangeLog:15 >> +2011-05-30 James Kozianski <koz@chromium.org> > > Teere are two ChangeLog entries. Done.
Kent Tamura
Comment 6 2011-05-30 22:54:42 PDT
Comment on attachment 95396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95396&action=review > Source/WebCore/ChangeLog:11 > + [Chromium] Make isValidProtocol() accept protocols with '+'. > + > + Also, detect syntax errors before security errors; some syntax errors > + will also trigger a security error, but it's more helpful to the > + programmer to know if they have a syntax error, which are well-defined > + in the spec, rather than a security error, which aren't. > + https://bugs.webkit.org/show_bug.cgi?id=61759 nit: Usually we use the order of <One-line summary> <Bug URL> <Description>
James Kozianski
Comment 7 2011-05-30 22:56:47 PDT
Created attachment 95397 [details] Patch
James Kozianski
Comment 8 2011-05-30 22:57:32 PDT
Comment on attachment 95396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95396&action=review >> Source/WebCore/ChangeLog:11 >> + https://bugs.webkit.org/show_bug.cgi?id=61759 > > nit: Usually we use the order of > <One-line summary> > <Bug URL> > > <Description> Done.
James Kozianski
Comment 9 2011-05-30 23:29:39 PDT
Committed r87713: <http://trac.webkit.org/changeset/87713>
Note You need to log in before you can comment on or make changes to this bug.