Bug 61751

Summary: Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Fix Basic Issue none

Joseph Pecoraro
Reported 2011-05-30 15:35:04 PDT
I was seeing the following error: TypeError: 'undefined' is not a function (evaluating 'InspectorFrontendHost.saveSessionSetting("debugger-enabled", "true")') From calling: InspectorFrontendHost.saveSessionSetting("debugger-enabled", "false"); Looking at the stub + IDL I saw: 1. in Stub but not IDL: attach, detach, search, canAttachWindow 2. in IDL but not Stub: requestAttachWindow, requestDetachWindow, saveSessionSetting This only adds the missing function which was causing visible issues. I think ideally I can probably remove everything in list (1) and add stubs for everything in list (2).
Attachments
[PATCH] Fix Basic Issue (1.23 KB, patch)
2011-05-30 15:38 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2011-05-30 15:38:00 PDT
Created attachment 95376 [details] [PATCH] Fix Basic Issue I'm a bit behind and need to update, but this fixes the basic issue. Feel free to r- and demand I look into removing/adding the other functions.
WebKit Commit Bot
Comment 2 2011-05-31 11:54:12 PDT
Comment on attachment 95376 [details] [PATCH] Fix Basic Issue Clearing flags on attachment: 95376 Committed r87744: <http://trac.webkit.org/changeset/87744>
WebKit Commit Bot
Comment 3 2011-05-31 11:54:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.