Bug 61748

Summary: [efl] Add ewk_util.h to EWebKit.h
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, gyuyoung.kim, leandro, lucas.de.marchi, rakuco, ryuan.choi, tkent, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2011-05-30 14:24:40 PDT
[efl] Add ewk_util.h to EWebKit.h
Attachments
Patch (1.12 KB, patch)
2011-05-30 14:25 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-05-30 14:25:48 PDT
Created attachment 95372 [details] Patch
Ryuan Choi
Comment 2 2011-05-30 14:37:18 PDT
Good. Does ewk_util_image_from_cairo_surface_add need to have EAPI ?
Gyuyoung Kim
Comment 3 2011-05-30 16:43:21 PDT
I think the function of ewk_util.h need to have EAPI for visibility.
Leandro Pereira
Comment 4 2011-05-31 09:59:16 PDT
(In reply to comment #3) > I think the function of ewk_util.h need to have EAPI for visibility. EAPI will be added on another patch, that also changes ewk_util.c (by adding a few functions used by DRT).
Lucas De Marchi
Comment 5 2011-05-31 16:18:34 PDT
(In reply to comment #4) > (In reply to comment #3) > > I think the function of ewk_util.h need to have EAPI for visibility. > > EAPI will be added on another patch, that also changes ewk_util.c (by adding a few functions used by DRT). Are you sure this function is EAPI? It seems very odd to me to call it from browser... For me it'd be a candidate to move to ewk_private.h
Raphael Kubo da Costa (:rakuco)
Comment 6 2011-06-10 09:16:37 PDT
Alright, closing the report -- the other functions which were going to be added to ewk_util ended up being added somewhere else, so there is not much point in exporting the header anymore.
Leandro Pereira
Comment 7 2011-06-16 13:21:05 PDT
Comment on attachment 95372 [details] Patch Clearing the flags.
Note You need to log in before you can comment on or make changes to this bug.