Summary: | [efl] Add ewk API to enable/disable developer extras. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, tkent, tonikitoo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Raphael Kubo da Costa (:rakuco)
2011-05-30 14:13:11 PDT
Created attachment 95370 [details]
Patch
Comment on attachment 95370 [details]
Patch
ok
Comment on attachment 95370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95370&action=review Otherwise, looks good > Source/WebKit/efl/ewk/ewk_view.cpp:2716 > +Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable) > +{ > + EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); > + EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); > + if (priv->settings.enable_developer_extras != enable) { Since this is EAPI and Eina_Bool could assume values other than 1 and 0, a protection is needed for the enable argument. See ewk_view_setting_enable_scripts_set() as an example. (In reply to comment #2) > (From update of attachment 95370 [details]) > ok I didn't see that you had given r+/cq+. Anyway, I think it's better to fix the small issue I pointed out before landing this. > I didn't see that you had given r+/cq+. Anyway, I think it's better to fix the small issue I pointed out before landing this.
Definitely!
If Lucas comment is added to this patch, looks good to me. Created attachment 95447 [details]
Fixed patch
(In reply to comment #7) > Created an attachment (id=95447) [details] > Fixed patch Adam, now it seems good. Could you rubber stamp it? Comment on attachment 95447 [details] Fixed patch Clearing flags on attachment: 95447 Committed r87765: <http://trac.webkit.org/changeset/87765> All reviewed patches have been landed. Closing bug. |