Bug 61725

Summary: [GTK] Implement JavaScript dialogs in MiniBrowser
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2011-05-30 03:48:15 PDT
runJavaScriptAlert, runJavaScriptConfirm and runJavaScriptPrompt are currently unimplemented in MiniBrowser.
Attachments
Patch (6.13 KB, patch)
2011-05-30 03:53 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-05-30 03:53:49 PDT
Created attachment 95332 [details] Patch
Martin Robinson
Comment 2 2011-05-30 07:22:05 PDT
Comment on attachment 95332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95332&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:191 > + char *buffer = (char *)g_malloc(length * sizeof(char)); You can omit sizeof(char) here. I'm pretty sure it's always one in C. Please put a space after the cast. > Tools/MiniBrowser/gtk/BrowserWindow.c:460 > + WKStringRef retval = (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK) ? WKStringCreateWithUTF8CString(gtk_entry_get_text(GTK_ENTRY(entry))) : 0; -> returnValue
Carlos Garcia Campos
Comment 3 2011-05-30 09:25:25 PDT
Committed r87690: <http://trac.webkit.org/changeset/87690>
Note You need to log in before you can comment on or make changes to this bug.