| Summary: | NRWT: Exception in verbose printing mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hao Zheng <zhenghao> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dpranke | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 95330 [details]
Proposed patch.
delegate to self._update
Comment on attachment 95330 [details]
Proposed patch.
LGTM. Good catch.
The commit-queue encountered the following flaky tests while processing attachment 95330 [details]: http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org) http/tests/websocket/tests/sub-protocol-with-space.html bug 61434 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 95330 [details] Proposed patch. Clearing flags on attachment: 95330 Committed r87774: <http://trac.webkit.org/changeset/87774> All reviewed patches have been landed. Closing bug. |
File "/usr/local/google/code/webkit.chromium/webkit/Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py", line 351, in print_progress self._meter.update("%s (%d%%): %d ran as expected, %d didn't," AttributeError: 'NoneType' object has no attribute 'update' Caused by https://bugs.webkit.org/show_bug.cgi?id=60326