Bug 61712

Summary:

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	simon.fraser: review+

Description Jer Noble 2011-05-29 14:48:08 PDT

Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page

Comment 1 Jer Noble 2011-05-29 15:07:29 PDT

<rdar://problem/9521845>

Comment 2 Jer Noble 2011-05-29 15:09:23 PDT

Created attachment 95302 [details]
Patch

Comment 3 Simon Fraser (smfr) 2011-05-29 15:22:08 PDT

Comment on attachment 95302 [details]
Patch

There's nothing here that maintains m_containsFullScreenElement in the face of DOM operations

Comment 4 Jer Noble 2011-05-29 16:57:45 PDT

Created attachment 95307 [details]
Patch

Comment 5 Simon Fraser (smfr) 2011-05-29 17:08:49 PDT

Comment on attachment 95307 [details]
Patch

I'm not really a fan of how we touch style in ancestor documents, and I suspect that there's a way to re-parent whole iframes that will escape your bit maintenance. But this seems like an OK approach in the short term. Please test thoroughly.

Please file a new bug to explore alternative ways to fix this, e.g. by doing stuff in RenderLayer.

Oh, and a testcase would be good.

Comment 6 Jer Noble 2011-05-29 19:05:39 PDT

Committed r87660: <http://trac.webkit.org/changeset/87660>