Bug 61712

Summary: Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Jer Noble
Reported 2011-05-29 14:48:08 PDT
Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
Attachments
Patch (13.88 KB, patch)
2011-05-29 15:09 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (15.90 KB, patch)
2011-05-29 16:57 PDT, Jer Noble 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-05-29 15:07:29 PDT
<rdar://problem/9521845>
Jer Noble
Comment 2 2011-05-29 15:09:23 PDT
Created attachment 95302 [details] Patch
Simon Fraser (smfr)
Comment 3 2011-05-29 15:22:08 PDT
Comment on attachment 95302 [details] Patch There's nothing here that maintains m_containsFullScreenElement in the face of DOM operations
Jer Noble
Comment 4 2011-05-29 16:57:45 PDT
Created attachment 95307 [details] Patch
Simon Fraser (smfr)
Comment 5 2011-05-29 17:08:49 PDT
Comment on attachment 95307 [details] Patch I'm not really a fan of how we touch style in ancestor documents, and I suspect that there's a way to re-parent whole iframes that will escape your bit maintenance. But this seems like an OK approach in the short term. Please test thoroughly. Please file a new bug to explore alternative ways to fix this, e.g. by doing stuff in RenderLayer. Oh, and a testcase would be good.
Jer Noble
Comment 6 2011-05-29 19:05:39 PDT
Committed r87660: <http://trac.webkit.org/changeset/87660>
Note You need to log in before you can comment on or make changes to this bug.