Bug 61707

Summary: Race condition in full screen controller, which leads to problem when web process crashes
Product: WebKit Reporter: Darin Adler <darin>
Component: MediaAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Description Darin Adler 2011-05-29 13:07:52 PDT
Race condition in full screen controller, which leads to problem when web process crashes
Comment 1 Darin Adler 2011-05-29 13:08:49 PDT
Created attachment 95295 [details]
Patch
Comment 2 Darin Adler 2011-05-29 13:12:32 PDT
Committed r87644: <http://trac.webkit.org/changeset/87644>
Comment 3 Darin Adler 2011-05-29 16:52:52 PDT
The initial patch was too simple-minded and could result in a WKView leak.
Comment 4 Darin Adler 2011-05-29 16:59:13 PDT
Created attachment 95308 [details]
Patch
Comment 5 Darin Adler 2011-05-29 17:04:50 PDT
Comment on attachment 95308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95308&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:424
> +    [self release]; // Balanced by retain in exitAcceleratedCompositingMode below.

I have corrected this to say “above” locally.
Comment 6 mitz 2011-05-29 17:07:34 PDT
Comment on attachment 95308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95308&action=review

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:410
> +    if (!_isExitingAcceleratedCompositingMode)
> +        return;

This shouldn’t happen. It’s good to be prepared for this, but I suggest asserting that it doesn’t happen, in addition.

>> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:424
>> +    [self release]; // Balanced by retain in exitAcceleratedCompositingMode below.
> 
> I have corrected this to say “above” locally.

Please also correct the name of the method the comment is referring to!
Comment 7 Darin Adler 2011-05-29 17:19:51 PDT
Committed r87656: <http://trac.webkit.org/changeset/87656>