|Summary:||Simplify flow of CachedResourceRequest creation|
|Product:||WebKit||Reporter:||Nate Chapin <japhet>|
|Component:||WebCore Misc.||Assignee:||Nate Chapin <japhet>|
|Severity:||Normal||CC:||abarth, ap, commit-queue, koivisto|
|Version:||528+ (Nightly build)|
Description Nate Chapin 2011-05-27 14:18:38 PDT
The creation of a CachedResourceRequest seems really circular. CachedResourceLoader calls CachedResource::load(), which then calls back to CachedResourceLoader::load(), which finally calls CachedResourceRequest::load(). I'm going to upload a patch and let others decide whether it's actually prettier than what we have now.
Comment 2 Adam Barth 2011-05-27 14:34:43 PDT
Comment on attachment 95215 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=95215&action=review > Source/WebCore/loader/cache/CachedFont.cpp:-100 > - dl->load(this, false); We shouldn't call CachedResourceLoader "dl". That's an echo of the horrible "DocLoader" name.
Comment 3 Antti Koivisto 2011-05-30 00:18:10 PDT
Comment on attachment 95215 [details] patch it's better, r=me
Comment 4 WebKit Commit Bot 2011-05-30 00:45:55 PDT
Comment on attachment 95215 [details] patch Clearing flags on attachment: 95215 Committed r87679: <http://trac.webkit.org/changeset/87679>
Comment 5 WebKit Commit Bot 2011-05-30 00:46:01 PDT
All reviewed patches have been landed. Closing bug.