Bug 61666

Summary: Simplify flow of CachedResourceRequest creation
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, commit-queue, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Nate Chapin
Reported 2011-05-27 14:18:38 PDT
The creation of a CachedResourceRequest seems really circular. CachedResourceLoader calls CachedResource::load(), which then calls back to CachedResourceLoader::load(), which finally calls CachedResourceRequest::load(). I'm going to upload a patch and let others decide whether it's actually prettier than what we have now.
Attachments
patch (5.55 KB, patch)
2011-05-27 14:23 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2011-05-27 14:23:04 PDT
Created attachment 95215 [details] patch
Adam Barth
Comment 2 2011-05-27 14:34:43 PDT
Comment on attachment 95215 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=95215&action=review > Source/WebCore/loader/cache/CachedFont.cpp:-100 > - dl->load(this, false); We shouldn't call CachedResourceLoader "dl". That's an echo of the horrible "DocLoader" name.
Antti Koivisto
Comment 3 2011-05-30 00:18:10 PDT
Comment on attachment 95215 [details] patch it's better, r=me
WebKit Commit Bot
Comment 4 2011-05-30 00:45:55 PDT
Comment on attachment 95215 [details] patch Clearing flags on attachment: 95215 Committed r87679: <http://trac.webkit.org/changeset/87679>
WebKit Commit Bot
Comment 5 2011-05-30 00:46:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.