Bug 61648

Summary: Remove extra args from scroll functions
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: Layout and RenderingAssignee: Peter Kasting <pkasting>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, tonikitoo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
webkit.review.bot: commit-queue-
Patch v2
none
Patch v3 none

Peter Kasting
Reported 2011-05-27 10:51:42 PDT
RenderLayer::scrollRectToVisible() and RenderBox::canBeProgrammaticallyScrolled() both have unused boolean arguments. I can remove them. (This bug split off from bug 47036.)
Attachments
Patch v1 (14.97 KB, patch)
2011-06-02 14:58 PDT, Peter Kasting 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch v2 (15.75 KB, patch)
2011-06-02 17:26 PDT, Peter Kasting 		no flags
DetailsFormatted DiffDiff
Patch v3 (15.75 KB, patch)
2011-06-03 11:04 PDT, Peter Kasting 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Kasting
Comment 1 2011-06-02 14:58:39 PDT
Created attachment 95816 [details] Patch v1
WebKit Review Bot
Comment 2 2011-06-02 15:14:59 PDT
Comment on attachment 95816 [details] Patch v1 Attachment 95816 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8760238
Gustavo Noronha (kov)
Comment 3 2011-06-02 16:57:36 PDT
Comment on attachment 95816 [details] Patch v1 Attachment 95816 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8755950
WebKit Review Bot
Comment 4 2011-06-02 17:09:11 PDT
Comment on attachment 95816 [details] Patch v1 Attachment 95816 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8757572
Peter Kasting
Comment 5 2011-06-02 17:26:27 PDT
Created attachment 95839 [details] Patch v2
Antonio Gomes
Comment 6 2011-06-02 19:03:13 PDT
Comment on attachment 95839 [details] Patch v2 does it apply to trunk, so we can exersise the buildbots?
Peter Kasting
Comment 7 2011-06-03 11:04:53 PDT
Created attachment 95927 [details] Patch v3
Antonio Gomes
Comment 8 2011-06-03 11:12:51 PDT
Comment on attachment 95927 [details] Patch v3 r=me as long as bots are happy. Nice clean up!
WebKit Review Bot
Comment 9 2011-06-06 12:21:44 PDT
Comment on attachment 95927 [details] Patch v3 Clearing flags on attachment: 95927 Committed r88178: <http://trac.webkit.org/changeset/88178>
WebKit Review Bot
Comment 10 2011-06-06 12:21:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.