Bug 61632

Summary:

[GTK] Use alloca() if available for control messages in ConnectionUnix

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

bugs-noreply

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	mrobinson: review-

Carlos Garcia Campos

Reported 2011-05-27 07:39:38 PDT

It avoids some heap allocations for the message control buffer when sending and receiving messages.

Attachments
Patch (3.76 KB, patch) 2011-05-27 07:43 PDT, Carlos Garcia Campos	mrobinson: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2011-05-27 07:43:41 PDT

Created attachment 95172 [details] Patch

Martin Robinson

Comment 2 2011-07-11 08:50:50 PDT

Comment on attachment 95172 [details] Patch While I admit that this may have some performance benefit, I don't think we should add it until we know what sort of performance benefit. Also I have concerns about using alloca with large data structures.

Note You need to log in before you can comment on or make changes to this bug.