Bug 61615

Summary: IndexedDB: Support mutating cursors on top of LevelDB
Product: WebKit Reporter: Hans Wennborg <hans>
Component: New BugsAssignee: Hans Wennborg <hans>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, dgrogan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tonyg: review+

Description Hans Wennborg 2011-05-27 01:09:15 PDT
IndexedDB: Support mutating cursors on top of LevelDB
Comment 1 Hans Wennborg 2011-05-27 01:32:52 PDT
Created attachment 95140 [details]
Patch
Comment 2 Tony Gentilcore 2011-05-27 06:33:23 PDT
Comment on attachment 95140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95140&action=review

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:141
> +        void reSeekTreeIterator() const;

I suggest a more idiomatic name than reSeek, maybe refreshTreeIterator() or updateTreeIterator()?
Comment 3 Hans Wennborg 2011-05-27 06:50:32 PDT
(In reply to comment #2)
> (From update of attachment 95140 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95140&action=review
> 
> > Source/WebCore/platform/leveldb/LevelDBTransaction.h:141
> > +        void reSeekTreeIterator() const;
> 
> I suggest a more idiomatic name than reSeek, maybe refreshTreeIterator() or updateTreeIterator()?
Done.

Thanks, Tony!
Comment 4 Hans Wennborg 2011-05-27 07:02:47 PDT
Committed r87508: <http://trac.webkit.org/changeset/87508>