Bug 61615 - IndexedDB: Support mutating cursors on top of LevelDB
Summary: IndexedDB: Support mutating cursors on top of LevelDB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-27 01:09 PDT by Hans Wennborg
Modified: 2011-05-27 07:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (17.65 KB, patch)
2011-05-27 01:32 PDT, Hans Wennborg 		tonyg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-05-27 01:09:15 PDT 
IndexedDB: Support mutating cursors on top of LevelDB
Comment 1 Hans Wennborg 2011-05-27 01:32:52 PDT 
Created attachment 95140 [details]
Patch
Comment 2 Tony Gentilcore 2011-05-27 06:33:23 PDT 
Comment on attachment 95140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95140&action=review

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:141
> +        void reSeekTreeIterator() const;

I suggest a more idiomatic name than reSeek, maybe refreshTreeIterator() or updateTreeIterator()?
Comment 3 Hans Wennborg 2011-05-27 06:50:32 PDT 
(In reply to comment #2)
> (From update of attachment 95140 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95140&action=review
> 
> > Source/WebCore/platform/leveldb/LevelDBTransaction.h:141
> > +        void reSeekTreeIterator() const;
> 
> I suggest a more idiomatic name than reSeek, maybe refreshTreeIterator() or updateTreeIterator()?
Done.

Thanks, Tony!
Comment 4 Hans Wennborg 2011-05-27 07:02:47 PDT 
Committed r87508: <http://trac.webkit.org/changeset/87508>