Summary: | Implement webkit margin collapse CSS properties in CSSStyleApplyProperty | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luke Macpherson <macpherson> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dglazkov, eric, macpherson | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Luke Macpherson
2011-05-26 18:47:59 PDT
Created attachment 95091 [details]
Patch
Comment on attachment 95091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95091&action=review OK. > Source/WebCore/css/CSSStyleSelector.cpp:-4976 > - m_style->setMarginBeforeCollapse(MCOLLAPSE); > - m_style->setMarginAfterCollapse(MCOLLAPSE); I assume initial* correctly returns these values? Comment on attachment 95091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95091&action=review >> Source/WebCore/css/CSSStyleSelector.cpp:-4976 >> - m_style->setMarginAfterCollapse(MCOLLAPSE); > > I assume initial* correctly returns these values? That is correct. These should have been calling RenderStyle::initialMarginBeforeCollapse/AfterCollapse, which return MCOLLAPSE. Comment on attachment 95091 [details]
Patch
I can't remember if you're a committer yet or not, but I'll set the cq+ just in case. :)
Comment on attachment 95091 [details] Patch Clearing flags on attachment: 95091 Committed r87474: <http://trac.webkit.org/changeset/87474> All reviewed patches have been landed. Closing bug. |