Bug 61589

Summary:

Implement webkit margin collapse CSS properties in CSSStyleApplyProperty

Product:

WebKit

Reporter:

Luke Macpherson <macpherson>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, eric, macpherson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Luke Macpherson 2011-05-26 18:47:59 PDT

Implement webkit margin collapse CSS properties in CSSStyleApplyProperty

Comment 1 Luke Macpherson 2011-05-26 18:51:53 PDT

Created attachment 95091 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-05-26 19:34:56 PDT

Comment on attachment 95091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95091&action=review

OK.

> Source/WebCore/css/CSSStyleSelector.cpp:-4976
> -            m_style->setMarginBeforeCollapse(MCOLLAPSE);
> -            m_style->setMarginAfterCollapse(MCOLLAPSE);

I assume initial* correctly returns these values?

Comment 3 Luke Macpherson 2011-05-26 20:35:44 PDT

Comment on attachment 95091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95091&action=review

>> Source/WebCore/css/CSSStyleSelector.cpp:-4976
>> -            m_style->setMarginAfterCollapse(MCOLLAPSE);
> 
> I assume initial* correctly returns these values?

That is correct. These should have been calling RenderStyle::initialMarginBeforeCollapse/AfterCollapse, which return MCOLLAPSE.

Comment 4 Eric Seidel (no email) 2011-05-26 21:08:08 PDT

Comment on attachment 95091 [details]
Patch

I can't remember if you're a committer yet or not, but I'll set the cq+ just in case. :)

Comment 5 WebKit Commit Bot 2011-05-26 23:27:11 PDT

Comment on attachment 95091 [details]
Patch

Clearing flags on attachment: 95091

Committed r87474: <http://trac.webkit.org/changeset/87474>

Comment 6 WebKit Commit Bot 2011-05-26 23:27:16 PDT

All reviewed patches have been landed.  Closing bug.