Summary: | Transition to full screen video animates in wrong location when scrolled | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
Component: | Media | Assignee: | Jon Lee <jonlee> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.6 | ||||||
Attachments: |
|
Description
Jon Lee
2011-05-26 14:14:48 PDT
Created attachment 95050 [details]
Patch
Comment on attachment 95050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95050&action=review > Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:56 > + void animateFullScreen(CATransform3D startTransform, CATransform3D endTransform, float duration, id listener); Should these arguments be const CATransform3D& instead of passing by value? (In reply to comment #2) > (From update of attachment 95050 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95050&action=review > > > Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:56 > > + void animateFullScreen(CATransform3D startTransform, CATransform3D endTransform, float duration, id listener); > > Should these arguments be const CATransform3D& instead of passing by value? Good suggestion. Taken. Committed r87456: <http://trac.webkit.org/changeset/87456> |