Bug 61559

Summary: Transition to full screen video animates in wrong location when scrolled
Product: WebKit Reporter: Jon Lee <jonlee>
Component: MediaAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch darin: review+

Description Jon Lee 2011-05-26 14:14:48 PDT
<rdar://problem/9496054>
Comment 1 Jon Lee 2011-05-26 15:02:29 PDT
Created attachment 95050 [details]
Patch
Comment 2 Darin Adler 2011-05-26 16:54:23 PDT
Comment on attachment 95050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95050&action=review

> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:56
> +    void animateFullScreen(CATransform3D startTransform, CATransform3D endTransform, float duration, id listener);

Should these arguments be const CATransform3D& instead of passing by value?
Comment 3 Jon Lee 2011-05-26 17:27:24 PDT
(In reply to comment #2)
> (From update of attachment 95050 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95050&action=review
> 
> > Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:56
> > +    void animateFullScreen(CATransform3D startTransform, CATransform3D endTransform, float duration, id listener);
> 
> Should these arguments be const CATransform3D& instead of passing by value?

Good suggestion. Taken.
Comment 4 Jon Lee 2011-05-26 17:29:57 PDT
Committed r87456: <http://trac.webkit.org/changeset/87456>