| Summary: | [chromium] Be robust to empty viewports in the compositor | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||
| Component: | WebCore Misc. | Assignee: | Adrienne Walker <enne> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | enne, jamesr, nduca | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adrienne Walker
2011-05-26 11:01:19 PDT
Created attachment 95008 [details]
Patch
See: http://code.google.com/p/chromium/issues/detail?id=83961 The order of events that causes this is that the layer renderer is created and a doComposite event is called while the layer renderer (and the main frame) have an empty viewport rect. This might be able to be fixed at a higher level too, but I think this code should be robust to the possibility of an empty content rect. Comment on attachment 95008 [details]
Patch
R=me. the m_updateRect = IntRect() before the early out confused me for a bit, maybe stick the clear inside the branch?
(In reply to comment #3) > (From update of attachment 95008 [details]) > R=me. the m_updateRect = IntRect() before the early out confused me for a bit, maybe stick the clear inside the branch? Thanks. I'll clean that up before landing. Committed r87409: <http://trac.webkit.org/changeset/87409> |