Bug 61529

Summary: Web Inspector: TimelinePanel should not modify input timeline data when processing timeline event
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 61098    
Description Flags
yurys: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01 none

Description Andrey Kosyakov 2011-05-26 07:48:36 PDT
We don't want TimelinePanel._addRecordToTimeline to have any side effects on the source event data, as the data may be dispatched further (e.g. to extensions, see bug 61098).
Comment 1 Andrey Kosyakov 2011-05-26 07:51:21 PDT
Created attachment 94974 [details]
Comment 2 Ilya Tikhonovsky 2011-05-26 08:07:12 PDT
Comment on attachment 94974 [details]

Comment 3 Yury Semikhatsky 2011-05-26 08:46:34 PDT
Comment on attachment 94974 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=94974&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:359
> +                }

; is missing.

> Source/WebCore/inspector/front-end/TimelinePanel.js:360
> +                children = record.children.slice(1).concat(record.children);

This line is somewhat different from what it used to be.

> Source/WebCore/inspector/front-end/TimelinePanel.js:1027
> +    _getRecordDetails: function(sendRequestRecords)

The parameter is unused, please remove it here and in _refreshDetails
Comment 4 Andrey Kosyakov 2011-05-26 09:03:04 PDT
Created attachment 94983 [details]

- fixed children flattening for function calls
- removed unused parameter from _refreshDetails/_getRecordDetauls()
Comment 5 WebKit Review Bot 2011-05-26 09:27:18 PDT
Comment on attachment 94983 [details]

Attachment 94983 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8733982

New failing tests:
Comment 6 WebKit Review Bot 2011-05-26 09:27:22 PDT
Created attachment 94988 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Andrey Kosyakov 2011-05-26 09:38:25 PDT
A variation of patch committed manually as r87395: http://trac.webkit.org/changeset/87395

(fixed script name/line for non-timer events, rebaselined custom test expectation for chromium/linux)