Bug 61504

Summary:

[Qt] Multiple drop events when doing DnD of images.

Product:

WebKit

Reporter:

Dawit A. <adawit>

Component:

UI Events

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, aparna.nand, ariya.hidayat, ben, commit-queue, kling

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test case	none
Patch v01 for review	none

Description Dawit A. 2011-05-25 21:52:10 PDT

Based on a downstream report, https://bugs.kde.org/show_bug.cgi?id=237759, dragging and dropping any image from any website using QtWebKit from the 2.2 branch produces multiple drop events. This can be reproduced using QtTestBrowser and visiting any site that contains an image. Though I highly doubt it, this issue could potentially be solved the patch that was proposed to fix bug# 58732, but was never landed in webkit ?? Dunno, but the issue is 100% perence reproducable for me.

Comment 1 Andreas Kling 2011-05-27 05:31:57 PDT

Do we have a test case for this?

Comment 2 Dawit A. 2011-05-28 13:39:40 PDT

Created attachment 95271 [details]
Test case

Comment 3 Aparna Nandyal 2011-05-29 10:45:10 PDT

Can you please give more clarity on steps to reproduce the problem? For example, I have opened QtTestBrowser and visited a site that has images. Am I expected to drag the image into some folder?

Comment 4 Dawit A. 2011-05-29 11:46:10 PDT

(In reply to comment #3)
> Can you please give more clarity on steps to reproduce the problem? For example, I have opened QtTestBrowser and visited a site that has images. Am I expected to drag the image into some folder?

Yes. There is no need to visit another site. Simply click on the attached test case file, then drag and drop the image to a folder of your choice.

Comment 5 Aparna Nandyal 2011-05-30 11:25:32 PDT

Finally able to reproduce the problem on trunk. Had problems seeing the bug in nautilus initially. Had to change the folder permissions to be able to see the bug.

Comment 6 Andreas Kling 2011-05-30 12:53:59 PDT

This looks suspicious: <http://trac.webkit.org/changeset/49201>

Comment 7 Aparna Nandyal 2011-05-31 03:59:04 PDT

(In reply to comment #6)
> This looks suspicious: <http://trac.webkit.org/changeset/49201>

Your suspicion is right. The image url is getting appended twice in the above code.

Comment 8 Aparna Nandyal 2011-05-31 21:49:34 PDT

Created attachment 95546 [details]
Patch v01 for review

The patch fixes problem which was caused by duplicate url entries.

Comment 9 Andreas Kling 2011-06-02 04:42:36 PDT

Comment on attachment 95546 [details]
Patch v01 for review

r=me.

Comment 10 WebKit Commit Bot 2011-06-02 05:11:02 PDT

Comment on attachment 95546 [details]
Patch v01 for review

Clearing flags on attachment: 95546

Committed r87897: <http://trac.webkit.org/changeset/87897>

Comment 11 WebKit Commit Bot 2011-06-02 05:11:07 PDT

All reviewed patches have been landed.  Closing bug.

Comment 12 Ademar Reis 2011-06-02 06:10:46 PDT

(In reply to comment #10)
> (From update of attachment 95546 [details])
> Clearing flags on attachment: 95546
> 
> Committed r87897: <http://trac.webkit.org/changeset/87897>

No tests? Maybe a test like the one from bug #61314 could be used?

Comment 13 Ademar Reis 2011-06-02 07:45:29 PDT

Revision r87897 cherry-picked into qtwebkit-2.2 with commit 11f8b63 <http://gitorious.org/webkit/qtwebkit/commit/11f8b63>