Summary: | MemoryPressureHandler class should not be in WebCore/platform | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||||||||||
Component: | WebCore Misc. | Assignee: | Michael Saboff <msaboff> | ||||||||||||||
Status: | ASSIGNED --- | ||||||||||||||||
Severity: | Normal | CC: | eric, ggaren, gustavo, msaboff, rakuco, sam, webkit.review.bot, xan.lopez, yongjun_zhang | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 21354 | ||||||||||||||||
Attachments: |
|
Description
Michael Saboff
2011-05-25 15:55:59 PDT
Created attachment 100453 [details]
Proposed Patch
Moved the MemoryPressureHandler* source/header files from WebCore/platform to WebCore/page
I think you also need to change Source/WebCore/WebCore.xcodeproj/project.pbxproj to support the move on Mac. Besides that, the change looks good. Comment on attachment 100453 [details]
Proposed Patch
As Michael said, this will break the mac as is.
Created attachment 100771 [details]
Patch to incorporate Michael & Sam's review comment
Modified the xcodeproj file & now it is building fine in Mac.
Can you upload another one that merges cleanly with the bots so that we can see it if it really builds on the mac. Created attachment 100936 [details]
Patch re-created on latest code base
There was problem applying the previous patch. So, recreated the patch on the latest code base.
Comment on attachment 100936 [details]
Patch re-created on latest code base
This will break the Lion build. You need to migrate MemoryPressureHandlerMac.mm as well.
Created attachment 123020 [details]
Move MemoryPressureHandler class from WebCore/platform to WebCore/page.
Comment on attachment 123020 [details] Move MemoryPressureHandler class from WebCore/platform to WebCore/page. Attachment 123020 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11282454 Created attachment 123065 [details]
fix gtk build break.
Created attachment 123141 [details]
Fix win build break.
Comment on attachment 123141 [details]
Fix win build break.
Seems reasonable.
Comment on attachment 123141 [details] Fix win build break. Rejecting attachment 123141 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: .mm patching file Source/WebCore/platform/MemoryPressureHandler.cpp rm 'Source/WebCore/platform/MemoryPressureHandler.cpp' patching file Source/WebCore/platform/MemoryPressureHandler.h rm 'Source/WebCore/platform/MemoryPressureHandler.h' patching file Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm rm 'Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 Full output: http://queues.webkit.org/results/11365779 |