Bug 61424

Summary: [BlackBerry][EFL][GTK][WIN][WX] Remove ScriptControllerXXX.cpp to reduce duplication
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebCore Misc.Assignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, gyuyoung.kim, kenneth, lucas.de.marchi, paroga, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2011-05-25 00:33:21 PDT
ScriptControllerBrew, ScriptControllerEfl, ScriptControllerGtk, ScriptControllerHaiku, ScriptControllerWin and ScriptControllerWx are almost same. I believe that mering them will reduce duplication.
Attachments
Patch (18.28 KB, patch)
2012-08-06 15:41 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (16.74 KB, patch)
2012-08-08 00:53 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-06-01 08:15:52 PDT
This bug is independet from CMake (bug 61350), so reopening it. This is more a general cleanup to reduce file copies!
Ryuan Choi
Comment 2 2012-08-06 15:41:00 PDT
Created attachment 156775 [details] Patch
Gyuyoung Kim
Comment 3 2012-08-07 02:00:40 PDT
Comment on attachment 156775 [details] Patch I think this is good refactoring. Thanks.
Ryosuke Niwa
Comment 4 2012-08-08 00:15:09 PDT
Comment on attachment 156775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156775&action=review > Source/WebCore/bindings/js/ScriptControllerDefault.cpp:40 > +PassRefPtr<JSC::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget) I would prefer moving it to ScriptController and if-def it for mac & qt.
Ryuan Choi
Comment 5 2012-08-08 00:53:18 PDT
Created attachment 157143 [details] Patch
Ryuan Choi
Comment 6 2012-08-08 00:54:19 PDT
(In reply to comment #4) > (From update of attachment 156775 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156775&action=review > > > Source/WebCore/bindings/js/ScriptControllerDefault.cpp:40 > > +PassRefPtr<JSC::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget) > > I would prefer moving it to ScriptController and if-def it for mac & qt. Ok, I moved like you mentioned.
Rob Buis
Comment 7 2012-08-10 10:18:14 PDT
Comment on attachment 157143 [details] Patch LGTM.
WebKit Review Bot
Comment 8 2012-08-10 19:03:06 PDT
Comment on attachment 157143 [details] Patch Clearing flags on attachment: 157143 Committed r125346: <http://trac.webkit.org/changeset/125346>
WebKit Review Bot
Comment 9 2012-08-10 19:03:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.