Summary: | QuickLooks quirk is expensive to calculate | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephanie Lewis <slewis> | ||||||||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | dglazkov, slewis, webkit.review.bot | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Stephanie Lewis
2011-05-24 18:01:31 PDT
Created attachment 94726 [details]
patch
Comment on attachment 94726 [details] patch Attachment 94726 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8726917 Created attachment 94728 [details]
patch - properly ifdef'd this time
Attachment 94728 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/loader/FrameLoader.cpp:2416: More than one command on the same line in if [whitespace/parens] [4]
Source/WebCore/loader/FrameLoader.cpp:2419: More than one command on the same line in if [whitespace/parens] [4]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 94728 [details] patch - properly ifdef'd this time Attachment 94728 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8734297 Created attachment 94729 [details]
patch
Comment on attachment 94726 [details] patch Attachment 94726 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8734295 Comment on attachment 94728 [details] patch - properly ifdef'd this time Attachment 94728 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8734299 Comment on attachment 94729 [details] patch Attachment 94729 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8726927 New failing tests: http/tests/cache/post-redirect-get.php Created attachment 94732 [details]
Archive of layout-test-results from ec2-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 94748 [details]
patch
Comment on attachment 94748 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=94748&action=review r+ with the following changes: > Source/WebCore/loader/FrameLoader.cpp:2416 > + if (request.cachePolicy() == ReloadIgnoringCacheData && ResourceRequest::useQuickLookResourceCachingQuirks() && !equalIgnoringCase(request.httpMethod(), "post")) You can put the !equalIgnoringCase(request.httpMethod(), "post") before the useQuickLookResourceCachingQuirks() for an even more "less likely to calculate the quicklooks quirks" setup. > Source/WebCore/platform/network/mac/ResourceRequestMac.mm:182 > + const char* bundleID = [[[NSBundle mainBundle] bundleIdentifier] UTF8String]; > + if (bundleID && !strcasecmp(bundleID, "com.apple.Safari")) > + return false; You should use applicationIsSafari() in RuntimeApplicationChecks |