Bug 61406
| Summary: | Move HTMLSelectElement::setMultiple logic to attribute handling/parsing code | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ahmad.saleem792, akeerthi, annevk, antaryami.pandia, ap, bfulgham, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Emil A Eklund
From comment on bug 60986:
<darin> It doesn’t make sense that setting multiple with the binding directly does something different than setting the multiple attribute; all the code to handle the change from single to multiple needs to be in the attribute handling/parsing code and none should be in the setMultiple function. I think all the code in setMultiple is probably wrong. We should test the behavior in other browsers to be sure but I think that is the way to go and this refinement of the code is not sufficient.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
rniwa - we still have this:
https://github.com/WebKit/WebKit/blob/5a8883c75f0a425515a601a4eb8de66e88ada97d/Source/WebCore/html/HTMLSelectElement.cpp#L426
Is this something still needed to be changed or this can be marked as "RESOLVED LATER" for future?
Anne van Kesteren
*** This bug has been marked as a duplicate of bug 252969 ***