Bug 61384

Summary: Let's just have one way to get the system page size, bokay?
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: fridrich.strba, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch oliver: review+

Description Geoffrey Garen 2011-05-24 12:16:50 PDT
Let's just have one way to get the system page size, bokay?
Comment 1 Geoffrey Garen 2011-05-24 12:17:07 PDT
Created attachment 94661 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-24 12:20:39 PDT
Attachment 94661 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeListsEfl.txt', ..." exit_code: 1

Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/JavaScriptCore/heap/MarkStack.h:234:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2011-05-24 12:27:18 PDT
Comment on attachment 94661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94661&action=review

> Source/JavaScriptCore/wtf/PageBlock.cpp:75
> +    return 256 * 1024;

wow....
Comment 4 Geoffrey Garen 2011-05-24 13:51:57 PDT
Committed r87198: <http://trac.webkit.org/changeset/87198>
Comment 5 Adam Roben (:aroben) 2011-05-26 13:03:35 PDT
*** Bug 58572 has been marked as a duplicate of this bug. ***