Summary: | Undo gets broken in contenteditable area when a text field's value is set by script | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Critical | CC: | adele, alex, darin, enrica, justin.garcia, leviw, morrita, sullivan, tkent, xji | ||||||
Priority: | P1 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-05-23 20:41:57 PDT
This is why simple-rte.rniwa.com doesn't work properly on WebKit / Chrome. Created attachment 94567 [details]
demo
Apparently, I forgot to attach the test case earlier. It turned out that this bug is nothing to with event handler. The problem reproduces whenever you modify input element's value.
Of course this is broken because we call clearUndoRedoOperations() in RenderTextControl::setInnerTextValue. Relevant changesets: http://trac.webkit.org/changeset/15565 http://trac.webkit.org/changeset/29748 Created attachment 94662 [details]
fixes the bug
Thanks for the review, Darin. Landing it now. Committed r87204: <http://trac.webkit.org/changeset/87204> |