Bug 61306

Summary: Is the YARR begin characters optimization still a win?
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, pvarga
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 45749, 61129    
Attachments:
Description Flags
The patch ggaren: review+

Gavin Barraclough
Reported 2011-05-23 14:09:50 PDT
It looks like the benefit of this optimization may have been lost since the BOL optimizations went in ('once through' flag). Disabling this optimization seems to have no impact on SunSpider performance, and I measure a 2% win on v8 w/ YARR interpreter by disabling. If disabling will simplify the code, fix bugs & improve performance, than that is what we should do. Do we have evidence that this is still a win?
Attachments
The patch (17.70 KB, patch)
2011-05-23 16:34 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-05-23 16:34:52 PDT
Created attachment 94517 [details] The patch
Geoffrey Garen
Comment 2 2011-05-23 17:02:15 PDT
Comment on attachment 94517 [details] The patch r=me
Gavin Barraclough
Comment 3 2011-05-23 17:10:24 PDT
Removing this optimization for now in r87109, open to re-landing if we can demonstrate a significant performance win.
Note You need to log in before you can comment on or make changes to this bug.